feat: check writing with Vale #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan van den Berg <[email protected]>
✅ Deploy Preview for ospobook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ospomindmap canceled.
|
|
After downloading ospo-book/content/en/taxonomy.md
10:326 error Did you really mean Vale.Spelling
'deliverables'?
79:50 error Did you really mean 'leades'? Vale.Spelling
ospo-book/content/en/glossary.md
20:35 error Did you really mean 'libre'? Vale.Spelling
20:50 error Did you really mean 'libre'? Vale.Spelling
39:63 error Did you really mean Vale.Spelling
'innerSource'?
57:117 error Did you really mean 'Hoving'? Vale.Spelling
72:44 error Did you really mean Vale.Spelling
'interoperate'?
80:46 error Did you really mean 'Chai'? Vale.Spelling
ospo-book/content/en/_index.md
14:25 error Did you really mean Vale.Spelling
'antipatterns'?
ospo-book/content/en/toc.md
14:19 error Did you really mean Vale.Spelling
'antipatterns'?
24:19 error Did you really mean Vale.Spelling
'antipatterns'?
35:19 error Did you really mean Vale.Spelling
'antipatterns'?
44:19 error Did you really mean Vale.Spelling
'antipatterns'?
53:84 error Did you really mean 'teh'? Vale.Spelling
54:18 error Did you really mean Vale.Spelling
'antipatterns'?
ospo-book/content/en/02-chapter.md
11:4 error Did you really mean Vale.Spelling
'Antipatterns'?
32:3 error Did you really mean Vale.Spelling
'ospowork'?
69:6 error Did you really mean 'Apendix'? Vale.Spelling
94:133 error Did you really mean 'Ibrahim'? Vale.Spelling
96:3 error Did you really mean Vale.Spelling
'opensourceinvolvementmodel'?
104:23 error Did you really mean Vale.Spelling
'activityparticipationcategorization'?
106:4 error Did you really mean Vale.Spelling
'Antipatterns'?
115:178 error Did you really mean Vale.Spelling
'Sonatype'?
115:461 error Remove 'very'. proselint.Very
ospo-book/content/en/01-chapter.md
9:4 error Did you really mean Vale.Spelling
'Antipatterns'?
51:193 error Did you really mean 'OSPO's'? Vale.Spelling
53:145 error Consider using 'flight proselint.GenderBias
attendant' instead of
'steward'.
114:121 error Did you really mean 'OSPO's'? Vale.Spelling
118:130 error Did you really mean 'dev'? Vale.Spelling
128:4 error Did you really mean Vale.Spelling
'Antipatterns'?
✖ 96 errors, 2 warnings and 0 suggestions in 23 files.
It might still need some tweaking, but it already catches some typos. |
|
The workflow will run on changed markdown files in the |
Signed-off-by: Jan van den Berg <[email protected]>
wordsmeanstuff
suggested changes
Sep 21, 2023
| (?:bunch|group|pack|herd) of rhinoceros: crash of rhinoceros | ||
| (?:bunch|group|pack|herd) of wild boar: sounder of wild boar | ||
| (?:bunch|group|pack|herd) of wild pigs: drift of wild pigs | ||
| (?:bunch|group|pack|herd) of zebras: zeal of wild pigs |
There was a problem hiding this comment.
looks like "zeal of wild pigs" should say "zeal of zebras". :)
There was a problem hiding this comment.
i was just poking around this linter and love all the rules you've made! well done.
There was a problem hiding this comment.
I cannot take credit for Proselint, if this is indeed an error, we can fix it upstream. Otherwise we can adjust or add rules to this.
|
this is cool @koozz ! didn't know about vale before! Thanks for working on it and great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.vale.ini.vale syncto download rules..vale/Vocab/TODO/accept.txt.Still some false positives and names to add to the vocabulary.
There's even a possibility to create an OSPO or TODO style based on one of the other styles (Redhat, Microsoft or Google), which would result in the whole book being written in a single style.